Scuba Sounds 1.0

[quartz]

this is pretty self-contained and relatively conservative, so I figure I might as well release it and see what other people think.

http://www.simplici7y.com/items/scuba-sounds


edit: now version 1.1

[quartz]

haha ok, so I just discovered that the way I implemented the mod causes the bubbles sound to also happen in vacuum levels. I'm going to have to redo this. many thanks to the mml guide again for not being clear about things.

[Hopper]

many thanks to the mml guide again for not being clear about things.

Many thanks to you for submitting a documentation patch to clear it up. Oh wait, you didn't.

[quartz]

Many thanks to you for submitting a documentation patch to clear it up. Oh wait, you didn't.

sorry, the mml is like 3 lines I figured it would be obvious what was going on.

in the "sounds" tag, the description for the "breath" attribute says it plays when you're underwater. it neglects to mention that it also plays when you're in a vacuum. this makes perfect sense, but it didn't occur to me to check that until after I'd already uploaded it to simplicity. the description also says it plays more often as your o2 bar gets lower, but in my testing it plays every 30 seconds on the dot, with the caveat that the timer does not reset to 0 but carries over when you go in and out of liquids (at least, that's what I think it's doing).

on a side note: would it be easy to add an mml variable to control the time interval? I'd love it if I could drop it to like 3 seconds, then I could have a real gasmask breath sound without playing tricks. I'm not sure what bungie had in mind for this before they ditched it, but 30 seconds is kinda far apart and is hard to do anything creative with.

[treellama]

the description also says it plays more often as your o2 bar gets lower, but in my testing it plays every 30 seconds on the dot, with the caveat that the timer does not reset to 0 but carries over when you go in and out of liquids (at least, that's what I think it's doing).

Code: Select all

// lolbungie
breathing_frequency = TICKS_PER_MINUTE/2;
/*
switch (player->suit_oxygen/TICKS_PER_MINUTE)
{
        case 0: breathing_frequency= TICKS_PER_MINUTE/6;
        case 1: breathing_frequency= TICKS_PER_MINUTE/5;
        case 2: breathing_frequency= TICKS_PER_MINUTE/4;
        case 3: breathing_frequency= TICKS_PER_MINUTE/3;
        default: breathing_frequency= TICKS_PER_MINUTE/2;
}
*/

[quartz]

would it be easy to expose that and let people type in a raw tick value or something?

after doing more testing, my scuba patch may be in trouble. I realized that in one or two places people have used the "underwater" sound as a dry-ground ambient sound, so I can't even get away with just changing that one sound slot without having side effects. having a real separate breath sound that's independent would be a lot cleaner, but at 30sec there's not a lot I can do.


edit: completely didn't see the comment markers in that code first time I read it.

[Wrkncacnter]

Maybe I'm missing something, but:
breathing_frequency = TICKS_PER_MINUTE/2;

Seems like it would happen every 30 seconds to me.

[quartz]

Seems like it would happen every 30 seconds to me.

yeah, look again, the whole bottom section is commented out. I totally missed that too and did this whole thing with a stopwatch and pen and paper. after I posted it I realized that tree was confirming what I said, not refuting it.


edit: looks like I didn't completely read what you wrote either.

[Wrkncacnter]

Yeah, that's why I didn't mention the irrelevant code. All I know is people are arguing about nothing.

[treellama]

edit: completely didn't see the comment markers in that code first time I read it.

They don't actually affect the behavior of that code

[quartz]

All I know is people are arguing about nothing.

well, I'm arguing that letting people change the timer would be immensely useful.

[quartz]

They don't actually affect the behavior of that code

I'm not great with the C family, but why not? does "player->suit_oxygen" retrieve the max value instead of the current value or something? the only other thing I can think of is that the division produces a float instead of an int, but I don't think that would be happening.

also: having the rate get faster and being able to control the scaling would be a nice touch, but I can't think of a clear way you'd expose that through an mml tag.

[treellama]

I'm not great with the C family, but why not?

Without a break, all the cases just fall through to the default case. Hopper found this one, and left it in comments because it's a great commentary on the original Marathon 2 code and the C programming language in general.

I posted it as a justification for why MML.html incorrectly describes the breathing behavior: at first glance, you might think it behaves just like the MML.html author did.

[quartz]

Without a break,

oh I missed that too. you manually have to write the word "break" in C?

[Wrkncacnter]

I think maybe these conversations would be more efficient if you joined #alephone on freenode sometime, quartz.

[quartz]

I think maybe these conversations would be more efficient if you joined #alephone on freenode sometime, quartz.

my current net connection is slow and incredibly flaky, so any form of live anything (chat/games/video/etc) doesn't work too well a lot of nights. chats in particular end up just being painful for everyone involved since I often get disconnected and/or half the messages don't go through.

[treellama]

I hope you're not paying an ISP for that!

Stealing a neighbor's wireless maybe?

[quartz]

I hope you're not paying an ISP for that!
Stealing a neighbor's wireless maybe?

both, effectively. my building complex doesn't allow people to install their own connections, we have to buy into a WLAN thing they have set up. which would be great if it worked half the time. signal reception at this end is poor, and their router shits the bed and reboots two or three times a week, going down for like 30+ min each time. most people here either don't seem to care or use cell tethering though, so it's probably not going to change any time soon.

[treellama]

Cantenna time!

[quartz]

Cantenna time!

heh, yeah. I haven't seen a laptop with an external antenna port in years though, and I dunno that it's worth buying a pc card just for that.

[L'howon]

heh, yeah. I haven't seen a laptop with an external antenna port in years though, and I dunno that it's worth buying a pc card just for that.

You could buy something relatively cheap like an Alfa Awus 036H. Only run you about 25-30 dollars, and the 9dB antenna that comes with it is quite powerful. There's also some Prism based USB dongles with 2-3dB antennas that might get the job done. Obviously the 9dB would work fine in it's own right, and coupled with a 'cantenna' (or a parabolic made out of a strainer) would easily net you enough range to get onto a open WAN. YMMV, never mind the legality of it, but it's a solution. (Plus it comes with some nice peripherals and a lengthy USB cable for wardriving shenanigans).